mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Desaulniers <nick.desaulniers@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: nick.desaulniers@gmail.com, jpoimboe@redhat.com,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [Patch v4] x86/build: don't add -maccumulate-outgoing-args w/o compiler support
Date: Mon,  8 May 2017 20:29:46 -0700	[thread overview]
Message-ID: <20170509032946.20444-1-nick.desaulniers@gmail.com> (raw)
In-Reply-To: <20170508032650.lefwzesoyv2pzbsz@treble>

Clang does not support this machine dependent option.

Older versions of GCC (pre 3.0) may not support this option, added in
2000, but it's unlikely they can still compile the kernel.

Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 arch/x86/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 4430dd489620..8c4dcba9a6a7 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -179,7 +179,8 @@ ifdef CONFIG_JUMP_LABEL
 endif
 
 ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1)
-	KBUILD_CFLAGS += -maccumulate-outgoing-args
+	# Unsupported by Clang.
+	KBUILD_CFLAGS += $(call cc-option,-maccumulate-outgoing-args,)
 endif
 
 # Stackpointer is addressed different for 32 bit and 64 bit x86
-- 
2.11.0

  reply	other threads:[~2017-05-09  3:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04  6:23 [PATCH] " Nick Desaulniers
2017-05-04 19:14 ` Josh Poimboeuf
2017-05-05  3:17   ` [Patch v2] x86/build: require only gcc use -maccumulate-outgoing-args Nick Desaulniers
2017-05-05  6:23     ` Ingo Molnar
2017-05-05  6:38       ` hpa
2017-05-05 13:05         ` Josh Poimboeuf
2017-05-06  3:05           ` [Patch v3] x86/build: don't add -maccumulate-outgoing-args w/o compiler support Nick Desaulniers
2017-05-08  3:26             ` Josh Poimboeuf
2017-05-09  3:29               ` Nick Desaulniers [this message]
2017-05-09  3:41                 ` [Patch v4] " Josh Poimboeuf
2017-05-09  6:41                 ` [tip:x86/urgent] x86/build: Don't " tip-bot for Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170509032946.20444-1-nick.desaulniers@gmail.com \
    --to=nick.desaulniers@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®