From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902AbdEIDln (ORCPT ); Mon, 8 May 2017 23:41:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54242 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbdEIDlm (ORCPT ); Mon, 8 May 2017 23:41:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 34059C056793 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 34059C056793 Date: Mon, 8 May 2017 22:41:40 -0500 From: Josh Poimboeuf To: Nick Desaulniers Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v4] x86/build: don't add -maccumulate-outgoing-args w/o compiler support Message-ID: <20170509034140.6etjxduw4sjenhgf@treble> References: <20170508032650.lefwzesoyv2pzbsz@treble> <20170509032946.20444-1-nick.desaulniers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170509032946.20444-1-nick.desaulniers@gmail.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 09 May 2017 03:41:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2017 at 08:29:46PM -0700, Nick Desaulniers wrote: > Clang does not support this machine dependent option. > > Older versions of GCC (pre 3.0) may not support this option, added in > 2000, but it's unlikely they can still compile the kernel. > > Signed-off-by: Nick Desaulniers > --- > arch/x86/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/Makefile b/arch/x86/Makefile > index 4430dd489620..8c4dcba9a6a7 100644 > --- a/arch/x86/Makefile > +++ b/arch/x86/Makefile > @@ -179,7 +179,8 @@ ifdef CONFIG_JUMP_LABEL > endif > > ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1) > - KBUILD_CFLAGS += -maccumulate-outgoing-args > + # Unsupported by Clang. > + KBUILD_CFLAGS += $(call cc-option,-maccumulate-outgoing-args,) > endif > > # Stackpointer is addressed different for 32 bit and 64 bit x86 Looks good to me, thanks for the iterations. Reviewed-by: Josh Poimboeuf -- Josh