From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751705AbdEIIB7 (ORCPT ); Tue, 9 May 2017 04:01:59 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28826 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdEIIB6 (ORCPT ); Tue, 9 May 2017 04:01:58 -0400 Date: Tue, 9 May 2017 11:01:41 +0300 From: Dan Carpenter To: Surender Polsani Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging : rtl8188eu : remove unnecessary else Message-ID: <20170509080141.x4abgtjcu7k3anxu@mwanda> References: <1494232980-27334-1-git-send-email-surenderpolsani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494232980-27334-1-git-send-email-surenderpolsani@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2017 at 02:13:00PM +0530, Surender Polsani wrote: > according to coding style else is not generally > useful after a break or return > > Signed-off-by: Surender Polsani > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > index d04b7fb..7420f55 100644 > --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > @@ -212,8 +212,7 @@ u8 rtw_hal_antdiv_before_linked(struct adapter *Adapter) > > rtw_antenna_select_cmd(Adapter, dm_swat_tbl->CurAntenna, false); > return true; > - } else { > + } > dm_swat_tbl->SWAS_NoLink_State = 0; > return false; > - } Nope. I think you really need to learn C programming before you send any more patches. regards, dan carpenter