From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752886AbdEIJGe (ORCPT ); Tue, 9 May 2017 05:06:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46858 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdEIJGd (ORCPT ); Tue, 9 May 2017 05:06:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1AD6C80474 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1AD6C80474 Date: Tue, 9 May 2017 11:06:31 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Support srccode output Message-ID: <20170509090631.GB4031@krava> References: <20170508202205.28520-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170508202205.28520-1-andi@firstfloor.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 09 May 2017 09:06:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 08, 2017 at 01:22:05PM -0700, Andi Kleen wrote: SNIP > diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c > index df051a52393c..542bfa7db53c 100644 > --- a/tools/perf/util/srcline.c > +++ b/tools/perf/util/srcline.c > @@ -479,6 +479,35 @@ char *__get_srcline(struct dso *dso, u64 addr, struct symbol *sym, > return srcline; > } > > +/* Returns filename and fills in line number in line */ > +char *get_srcline_split(struct dso *dso, u64 addr, > + bool unwind_inlines, unsigned *line) no need to pass unwind_inlines as arg if it's always true jirka