From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754718AbdEIQEq (ORCPT ); Tue, 9 May 2017 12:04:46 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59054 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbdEIQEo (ORCPT ); Tue, 9 May 2017 12:04:44 -0400 Date: Tue, 9 May 2017 09:04:41 -0700 From: Guenter Roeck To: Guru Das Srinagesh Cc: groeck@chromium.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: typec: Make undeclared symbol static Message-ID: <20170509160441.GA14061@roeck-us.net> References: <1494319733-28375-1-git-send-email-gurooodas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494319733-28375-1-git-send-email-gurooodas@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2017 at 01:48:53AM -0700, Guru Das Srinagesh wrote: > Fix sparse warning: > drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config' > was not declared. Should it be static? > > Signed-off-by: Guru Das Srinagesh Olivier Leveque already sent a similar patch last week. Thanks, Guenter > --- > drivers/staging/typec/tcpci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c > index 5e5be74..df72d8b 100644 > --- a/drivers/staging/typec/tcpci.c > +++ b/drivers/staging/typec/tcpci.c > @@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = { > .max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */ > }; > > -const struct tcpc_config tcpci_tcpc_config = { > +static const struct tcpc_config tcpci_tcpc_config = { > .type = TYPEC_PORT_DFP, > .default_role = TYPEC_SINK, > }; > -- > 2.7.4 >