From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756138AbdEIRDJ (ORCPT ); Tue, 9 May 2017 13:03:09 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60551 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755754AbdEIRDF (ORCPT ); Tue, 9 May 2017 13:03:05 -0400 X-ME-Sender: X-Sasl-enc: j8VmoGzhLBDSF0wX6T62CqXpPZZAkc0evrecJjLrBgsl 1494349384 Date: Tue, 9 May 2017 14:03:01 -0300 From: Henrique de Moraes Holschuh To: Andy Shevchenko Cc: Henrique de Moraes Holschuh , Darren Hart , Richard Weinberger , Andy Shevchenko , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] platform/x86: thinkpad_acpi: Add a comment about 0 in module_param_call() Message-ID: <20170509170301.GC19242@khazad-dum.debian.net> References: <20170509141721.15841-1-andriy.shevchenko@linux.intel.com> <20170509141721.15841-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170509141721.15841-3-andriy.shevchenko@linux.intel.com> X-GPG-Fingerprint1: 4096R/0x0BD9E81139CB4807: C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 May 2017, Andy Shevchenko wrote: > As per discussion [1] there are only few users of module_param_call() in > kernel which prevent to read module parameters back. > > It thinkpad_acpi driver there is even no method do so. Thus, for now, > add just a comment to explain why 0 is used as permissions in > module_param_call(). > > [1]: https://patchwork.ozlabs.org/patch/713245/ > > Cc: Richard Weinberger > Signed-off-by: Andy Shevchenko Acked-by: Henrique de Moraes Holschuh > --- > drivers/platform/x86/thinkpad_acpi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index e6fbb2579dd9..f5bc888b2ef4 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -9663,6 +9663,7 @@ module_param_named(enable, alsa_enable, bool, 0444); > MODULE_PARM_DESC(enable, "Enable the ALSA interface for the ACPI EC Mixer"); > #endif /* CONFIG_THINKPAD_ACPI_ALSA_SUPPORT */ > > +/* The module parameter can't be read back, that's why 0 is used here */ > #define TPACPI_PARAM(feature) \ > module_param_call(feature, set_ibm_param, NULL, NULL, 0); \ > MODULE_PARM_DESC(feature, "Simulates thinkpad-acpi procfs command at module load, see documentation") -- Henrique Holschuh "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot