From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755400AbdEKSQ3 (ORCPT ); Thu, 11 May 2017 14:16:29 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52912 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755273AbdEKSQ1 (ORCPT ); Thu, 11 May 2017 14:16:27 -0400 Date: Thu, 11 May 2017 14:16:23 -0400 (EDT) Message-Id: <20170511.141623.1200573443845531222.davem@davemloft.net> To: colin.king@canonical.com Cc: pavel.belous@aquantia.com, Dmitrii.Tarakanov@aquantia.com, Alexander.Loktionov@aquantia.com, vomlehn@texas.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ethernet: aquantia: remove redundant checks on error status From: David Miller In-Reply-To: <20170511172929.12951-1-colin.king@canonical.com> References: <20170511172929.12951-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 11 May 2017 10:34:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 11 May 2017 18:29:29 +0100 > From: Colin Ian King > > The error status err is initialized as zero and then being checked > several times to see if it is less than zero even when it has not > been updated. Since these checks are redundant we can remove these > as well as err and the error exit label err_exit. > > Detected by CoverityScan, CID#1398313 and CID#1398306 ("Logically > dead code") > > Signed-off-by: Colin Ian King Please enhance your commit message to also explain that the functions being called around these checks all return void, to make it clear that this isn't an issue of the return values not being checked. Thanks.