From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754448AbdEKGy4 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 11 May 2017 02:54:56 -0400
Received: from mail-wr0-f193.google.com ([209.85.128.193]:34512 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751028AbdEKGyy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 May 2017 02:54:54 -0400
Date: Thu, 11 May 2017 08:54:50 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC GIT PULL, v2] RCU changes for v4.12
Message-ID: <20170511065449.o4ujfelu7uuoaxic@gmail.com>
References: <20170501095915.rm4zi5z4ta44il5p@gmail.com>
 <20170509072640.sbvhtjy7mcw7ndo3@gmail.com>
 <CA+55aFyCqkbsHF6rZ79nHpCjJmNVT3ONqB0vyQTiB-GYQmts7Q@mail.gmail.com>
 <20170510195432.3yosw3jh7zfup4na@gmail.com>
 <CA+55aFxzKqvkdCvd00MZBA+svpNzjHXggFYNvfcanaKbVoseJA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFxzKqvkdCvd00MZBA+svpNzjHXggFYNvfcanaKbVoseJA@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Wed, May 10, 2017 at 12:54 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > Yeah, you are right and sorry about that - I have removed the patch
> > generation from my pull request scripts, so it shouldn't happen in
> > the future.
> 
> I do have to say, that during the later -rc series in particular when
> people send me smaller fixes, I enjoy seeing the full patches.

I find them useful too, and to answer your original question:

> > Nobody is ever going to review a 300kB patch that is ~7500 lines.

I _did_ skim over that 300K patch, because I always try to do a final manual check 
on the raw diffs I'm sending to you, and also to make it very clear what was sent 
from a full disclosure and security log POV, independent of the Git pull space. 

When patches are way too long, for example as the perf pull request diffs often 
are, I trim them, so it's never an absolute, script-only thing.

Still it's not an excuse:

 - I doubt anyone else but me would skim over a 30K (let alone a 300K) patch,

 - I also missed the pain large patches cause in Gmail replies (with Mutt that
   pain is considerably less),

 - plus, most importantly, I didn't notice that the extra RCU mode bloat was one 
   too many in an already sizable line-up of RCU complexity ...

Thanks,

	Ingo