From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932383AbdEKLmy (ORCPT ); Thu, 11 May 2017 07:42:54 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:59722 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbdEKLmx (ORCPT ); Thu, 11 May 2017 07:42:53 -0400 From: Arnd Bergmann To: Marcel Holtmann , Gustavo Padovan , Johan Hedberg Cc: Arnd Bergmann , Rob Herring , Bjorn Andersson , "David S. Miller" , Andy Gross , Loic Poulain , Sebastian Reichel , Javier Martinez Canillas , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] bluetooth: hci_ll: add proper SERDEV dependency Date: Thu, 11 May 2017 13:41:54 +0200 Message-Id: <20170511114223.2744939-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:CRD0aAoHb62U494n385cx0EforKfzksvUAIxcgmuEeiS2pEiGIF BxDvyMOwAt1DE1JAHK2r1MozzG/F3qf6OCEK8AuOYUYPDEUk95TGeRZGr87AF0KbsGabH35 t9GbnTZ4IN6Z1FBQ/88DGyR1iSvcnw0pN5WBWiEzIpHqydzatZ3+c1X3kkamrqaOoKZgoit iBRiaAeqVgVRTlDR6FRTQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ga0sijfvcU0=:q8mm4QJM6e+vxCzyzahCXa OyyE7XdQu6Nw0ZMWO7iC8DG7FmVdb3zhHqAWBTZJ+Sgi3db18ZsR96pyGPHm3a77cbb4GhMiI gwaz3V4mM7o2ZP2o66aBwLEsVmdBX4fO0EcNSnPCVD5NbGitE3fo7xgYEBRROUp37uXH56PfY AkmoZ1tIj7oM2iWukRQ8BY+4I0+T73pmaJ3M45QOTuCK93KOCutQzyVXpI0wgfwSnmbmpEW3w kJvsRCwXhCdDL/4Qb03JLP9VTQOJFi1Dtr9X9m0UyL9tFBcxuBnzaorH9gjs2sp5ONrzZCi88 GhWAJHumxE1bl/j+0LbuwdIX6Vf7evB2EscsdXvDbolTljhW0wStNvOEekBD3WoKqBOycfOzH p9BFRYVhhyyDDbgk3j2n6yClH4Ca9OvnG/onmXGrJAD2mGRdFHRYVF21x51FsBWwoqDv2HbrM 3HEcc6aB9sU38EK6h0wltNQo++1J2s1VqrdQZ/sdgF8eFGu8dGSmk2nGaCdBairiVpjZPy67Q eqVjZFOz/8OrMu0FgwtlVIGzmlVQZ6KMZ/PGKIs2tQYaAdggSJKCZinHXgB+nk//A7gQ68KXi Z7DvSdm8ovg7DzfHzow66QBdlqVrm8rTum6f4j6LfE/6BCrY/0h6Q7Mq0T+6qgm5OaDkpexIf 7IL4XacJSfvmIlMHg47l9/V1s1yUbeZiyJ63AUaFplZad79Eq9jt8GJ7+62Z3BIiMDjs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When SERDEV is a loadable module, and the HCI code is built-in, we get a link error: drivers/bluetooth/built-in.o: In function `ll_close': hci_ll.c:(.text+0x278d): undefined reference to `serdev_device_close' drivers/bluetooth/built-in.o: In function `hci_ti_probe': hci_ll.c:(.text+0x283c): undefined reference to `hci_uart_register_device' drivers/bluetooth/built-in.o: In function `ll_setup': hci_ll.c:(.text+0x289e): undefined reference to `serdev_device_set_flow_control' hci_ll.c:(.text+0x2b9c): undefined reference to `serdev_device_set_baudrate' drivers/bluetooth/built-in.o: In function `ll_open': hci_ll.c:(.text+0x2c77): undefined reference to `serdev_device_open' drivers/bluetooth/built-in.o: In function `ll_init': (.init.text+0x10d): undefined reference to `__serdev_device_driver_register' We already have CONFIG_BT_HCIUART_SERDEV as a Kconfig symbol that is set when the serdev code is reachable by a driver. Unlike the nokia driver, this one can also be built when serdev is completely disabled, so we add a dependency on serdev either being usable or disabled here. Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver support") Cc: Rob Herring Signed-off-by: Arnd Bergmann --- drivers/bluetooth/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index a63130ef2b98..b2cf0ae6b62d 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -133,6 +133,7 @@ config BT_HCIUART_ATH3K config BT_HCIUART_LL bool "HCILL protocol support" depends on BT_HCIUART + depends on BT_HCIUART_SERDEV || SERIAL_DEV_BUS=n help HCILL (HCI Low Level) is a serial protocol for communication between Bluetooth device and host. This protocol is required for -- 2.9.0