From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757686AbdEKRVY (ORCPT ); Thu, 11 May 2017 13:21:24 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:37295 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbdEKRVV (ORCPT ); Thu, 11 May 2017 13:21:21 -0400 Date: Thu, 11 May 2017 10:21:19 -0700 From: Guenter Roeck To: Guru Das Srinagesh Cc: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, yueyao@google.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: typec: Fix sparse warnings about incorrect types Message-ID: <20170511172119.GA23588@roeck-us.net> References: <1494481895-31605-1-git-send-email-gurooodas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494481895-31605-1-git-send-email-gurooodas@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2017 at 10:51:35PM -0700, Guru Das Srinagesh wrote: > Fix the following sparse warnings about incorrect type usage: > > fusb302.c:1028:32: warning: incorrect type in argument 1 (different base types) > fusb302.c:1028:32: expected unsigned short [unsigned] [usertype] header > fusb302.c:1028:32: got restricted __le16 const [usertype] header > fusb302.c:1484:32: warning: incorrect type in argument 1 (different base types) > fusb302.c:1484:32: expected unsigned short [unsigned] [usertype] header > fusb302.c:1484:32: got restricted __le16 [usertype] header > > Signed-off-by: Guru Das Srinagesh Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/fusb302/fusb302.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c > index 2cee9a9..3bec9d5 100644 > --- a/drivers/staging/typec/fusb302/fusb302.c > +++ b/drivers/staging/typec/fusb302/fusb302.c > @@ -1025,7 +1025,7 @@ static int fusb302_pd_send_message(struct fusb302_chip *chip, > buf[pos++] = FUSB302_TKN_SYNC1; > buf[pos++] = FUSB302_TKN_SYNC2; > > - len = pd_header_cnt(msg->header) * 4; > + len = pd_header_cnt_le(msg->header) * 4; > /* plug 2 for header */ > len += 2; > if (len > 0x1F) { > @@ -1481,7 +1481,7 @@ static int fusb302_pd_read_message(struct fusb302_chip *chip, > (u8 *)&msg->header); > if (ret < 0) > return ret; > - len = pd_header_cnt(msg->header) * 4; > + len = pd_header_cnt_le(msg->header) * 4; > /* add 4 to length to include the CRC */ > if (len > PD_MAX_PAYLOAD * 4) { > fusb302_log(chip, "PD message too long %d", len); > -- > 2.7.4 >