From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756692AbdEKTvD (ORCPT <rfc822;w@1wt.eu>);
        Thu, 11 May 2017 15:51:03 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:57118 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756338AbdEKTvC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 May 2017 15:51:02 -0400
Date: Thu, 11 May 2017 21:50:47 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Luca Abeni <luca.abeni@santannapisa.it>,
        Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing
 throttle and yielded
Message-ID: <20170511195047.qw7tf4c42evqszhq@hirez.programming.kicks-ass.net>
References: <20170510095044.6a04b2dc@gandalf.local.home>
 <20170511140116.4ojn67utqjp5x2j5@e106622-lin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170511140116.4ojn67utqjp5x2j5@e106622-lin>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 11, 2017 at 03:01:16PM +0100, Juri Lelli wrote:

> > -	if (dl_se->dl_yielded)
> > -		dl_se->dl_yielded = 0;
> > -	if (dl_se->dl_throttled)
> > -		dl_se->dl_throttled = 0;
> > +	dl_se->dl_yielded = 0;
> > +	dl_se->dl_throttled = 0;
> >  }
> 
> Looks good to me.
> 
> Peter, any particular reason why you wanted to first check the values?

No idea, could be general paranoia on unconditional writes or something.