From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757821AbdELPYx (ORCPT ); Fri, 12 May 2017 11:24:53 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34858 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755757AbdELPYw (ORCPT ); Fri, 12 May 2017 11:24:52 -0400 Date: Fri, 12 May 2017 11:24:47 -0400 (EDT) Message-Id: <20170512.112447.1421545301592945998.davem@davemloft.net> To: mq@ucw.cz Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsa@cumulusnetworks.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net Subject: Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer. From: David Miller In-Reply-To: <20170512111510.2697-1-mq@ucw.cz> References: <20170512111510.2697-1-mq@ucw.cz> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 12 May 2017 07:43:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Moskyto Matejka Date: Fri, 12 May 2017 13:15:10 +0200 > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); Please use "bool" and "true"/"false" for boolean values. What does ipv4 do in this situation? I'm hesitant to be OK with adding a new nlmsg flag just for this case if we solve this problem differently and using existing mechanisms elsewhere.