From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758126AbdELQPH (ORCPT ); Fri, 12 May 2017 12:15:07 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35294 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755233AbdELQPG (ORCPT ); Fri, 12 May 2017 12:15:06 -0400 Date: Fri, 12 May 2017 12:15:04 -0400 (EDT) Message-Id: <20170512.121504.1955818908238157662.davem@davemloft.net> To: garsilva@embeddedor.com Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: mv88e6xxx: add default case to switch From: David Miller In-Reply-To: <20170512031129.GA4065@embeddedgus> References: <20170511214814.Horde.otwLVFIaWFNJZ23PSdgsq_Z@gator4166.hostgator.com> <20170512031129.GA4065@embeddedgus> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 12 May 2017 08:33:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Thu, 11 May 2017 22:11:29 -0500 > Add default case to switch in order to avoid any chance of using an > uninitialized variable _low_, in case s->type does not match any of > the listed case values. > > Addresses-Coverity-ID: 1398130 > Suggested-by: Andrew Lunn > Signed-off-by: Gustavo A. R. Silva Applied, thanks.