From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933225AbdELQW1 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 12 May 2017 12:22:27 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:35402 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932920AbdELQWZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 12 May 2017 12:22:25 -0400
Date: Fri, 12 May 2017 12:22:23 -0400 (EDT)
Message-Id: <20170512.122223.341607427763777325.davem@davemloft.net>
To: julia.lawall@lip6.fr
Cc: netdev@vger.kernel.org, jon.mason@broadcom.com, andrew@lunn.ch,
        f.fainelli@gmail.com, kbuild-all@01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.DEB.2.20.1705122252440.3416@hadrien>
References: <alpine.DEB.2.20.1705122252440.3416@hadrien>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 12 May 2017 08:40:55 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Julia Lawall <julia.lawall@lip6.fr>
Date: Fri, 12 May 2017 22:54:23 +0800 (SGT)

> Device node iterators put the previous value of the index variable, so an
> explicit put causes a double put.
 ...
> @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev,
>  		if (r) {
>  			mdiobus_free(cb->mii_bus);
>  			devm_kfree(dev, cb);
> -			of_node_put(child_bus_node);
>  		} else {

I think we're instead simply missing a break; statement here.