From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757377AbdELHci (ORCPT ); Fri, 12 May 2017 03:32:38 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33070 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756642AbdELHch (ORCPT ); Fri, 12 May 2017 03:32:37 -0400 Date: Fri, 12 May 2017 09:32:33 +0200 From: Daniel Vetter To: Jose Abreu Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Alexey Brodkin , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Dave Airlie , Andrzej Hajda , Archit Taneja Subject: Re: [PATCH v3 0/6] Introduce new mode validation callbacks Message-ID: <20170512073232.yxknr556dal6isoh@phenom.ffwll.local> Mail-Followup-To: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Alexey Brodkin , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Dave Airlie , Andrzej Hajda , Archit Taneja References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 10:05:56AM +0100, Jose Abreu wrote: > This series is a follow up from the discussion at [1]. We start by > introducing crtc->mode_valid(), encoder->mode_valid() and > bridge->mode_valid() callbacks which will be used in followup > patches and also by cleaning the documentation a little bit. > > We proceed by introducing new helpers to call this new callbacks > at 2/6. > > At 3/6 a helper function is introduced that calls all mode_valid() > from a set of bridges. > > Next, at 4/6 we modify the connector probe helper so that only modes > which are supported by a given bridge+encoder+crtc combination are > probbed. > > At 5/6 we call all the mode_valid() callbacks for a given pipeline, > except the connector->mode_valid one, so that the mode is validated. > This is done before calling mode_fixup(). > > Finally, at 6/6 we use the new crtc->mode_valid() callback in arcpgu > and remove the atomic_check() callback. > > [1] https://patchwork.kernel.org/patch/9702233/ > > Jose Abreu (6): > drm: Add crtc/encoder/bridge->mode_valid() callbacks > drm: Add drm_{crtc/encoder/connector}_mode_valid() > drm: Introduce drm_bridge_mode_valid() > drm: Use new mode_valid() helpers in connector probe helper > drm: Use mode_valid() in atomic modeset > drm: arc: Use crtc->mode_valid() callback > > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Ville Syrjälä > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Andrzej Hajda > Cc: Archit Taneja Commented with an entire patch on patch 1, patches 2-5 are all Reviewed-by: Daniel Vetter But I think some more acks/r-bs would be really good, since this is quite a bit change in the helper infrastructure. But otherwise ready for merging imo. Can you pls also review my proposal for patch 1? Thanks, Daniel > > drivers/gpu/drm/arc/arcpgu_crtc.c | 39 ++++++---- > drivers/gpu/drm/drm_atomic_helper.c | 76 +++++++++++++++++++- > drivers/gpu/drm/drm_bridge.c | 33 +++++++++ > drivers/gpu/drm/drm_crtc_helper_internal.h | 13 ++++ > drivers/gpu/drm/drm_probe_helper.c | 103 ++++++++++++++++++++++++++- > include/drm/drm_bridge.h | 22 ++++++ > include/drm/drm_modeset_helper_vtables.h | 110 ++++++++++++++++++++++------- > 7 files changed, 348 insertions(+), 48 deletions(-) > > -- > 1.9.1 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch