From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756772AbdELM5r (ORCPT ); Fri, 12 May 2017 08:57:47 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:32947 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756120AbdELM5q (ORCPT ); Fri, 12 May 2017 08:57:46 -0400 Date: Fri, 12 May 2017 05:57:44 -0700 From: Matthew Giassa To: Greg KH Cc: hdegoede@redhat.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width Message-ID: <20170512125744.qvkafevxzu4x422o@darkstar> References: <1494553524-26385-1-git-send-email-matthew@giassa.net> <1494553524-26385-5-git-send-email-matthew@giassa.net> <20170512093008.GA19482@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170512093008.GA19482@kroah.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg KH [2017-05-12 11:30:08 +0200]: >On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: >> +#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration */ >> +#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address >> + */ >> +#define REG_HQ_DESA_8723B 0x0310 /* TX High Queue Descriptor >> + * Address >> + */ > >Ick, that looks worse to me now, doesn't it to you? Please leave the >original as-is. Will do. >Also, always test-build your patches :) Strange. That built fine on my Ubuntu x64 system: &> make -j2 drivers/staging/rtl8723bs/ ... CC arch/x86/kernel/asm-offsets.s GEN scripts/gdb/linux/constants.py CHK include/generated/asm-offsets.h UPD include/generated/asm-offsets.h CALL scripts/checksyscalls.sh LD drivers/staging/rtl8723bs/built-in.o $> gcc --version gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 >thanks, > >greg k-h Cheers! -- Matthew