From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756813AbdELNMW (ORCPT ); Fri, 12 May 2017 09:12:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41704 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756596AbdELNMV (ORCPT ); Fri, 12 May 2017 09:12:21 -0400 Date: Fri, 12 May 2017 15:12:10 +0200 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dan Carpenter , Hannes Reinecke , "Martin K. Petersen" Subject: Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std_inquiry() Message-ID: <20170512131210.GB13103@kroah.com> References: <20170511141237.094835992@linuxfoundation.org> <20170511141238.883852220@linuxfoundation.org> <1494588973.3965.68.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494588973.3965.68.camel@codethink.co.uk> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 12, 2017 at 12:36:13PM +0100, Ben Hutchings wrote: > On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Dan Carpenter > > > > commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream. > > > > We accidentally return an uninitialized variable on success. > > No we don't. > > > Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") > > Actually fixes: b78205c93297 ("scsi_dh_emc: switch to > scsi_execute_req_flags()") so this is only needed for 4.11.y. Ah, thanks for catching this, removed now from all of the queues. greg k-h