mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, viro@zeniv.linux.org.uk,
	akpm@linuxfoundation.org, avagin@virtuozzo.com,
	xemul@virtuozzo.com, mtk.manpages@gmail.com, gorcunov@openvz.org,
	avagin@openvz.org, jbaron@akamai.com, luto@amacapital.net
Subject: Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files
Date: Fri, 12 May 2017 15:00:18 -0700	[thread overview]
Message-ID: <20170512150018.b931c7f5295dd7484845fcec@linux-foundation.org> (raw)
In-Reply-To: <20170424154423.511592110@gmail.com>

On Mon, 24 Apr 2017 18:39:28 +0300 Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> With current epoll architecture target files are addressed
> with file_struct and file descriptor number, where the last
> is not unique. Moreover files can be transferred from another
> process via unix socket, added into queue and closed then
> so we won't find this descriptor in the task fdinfo list.
> 
> Thus to checkpoint and restore such processes CRIU needs to
> find out where exactly the target file is present to add it into
> epoll queue. For this sake one can use kcmp call where
> some particular target file from the queue is compared with
> arbitrary file passed as an argument.
> 
> Because epoll target files can have same file descriptor
> number but different file_struct a caller should explicitly
> specify the offset within.
> 
> To test if some particular file is matching entry inside
> epoll one have to
> 
>  - fill kcmp_epoll_slot structure with epoll file descriptor,
>    target file number and target file offset (in case if only
>    one target is present then it should be 0)
> 
>  - call kcmp as kcmp(pid1, pid2, KCMP_EPOLL_TFD, fd, &kcmp_epoll_slot)
>     - the kernel fetch file pointer matching file descriptor @fd of pid1
>     - lookups for file struct in epoll queue of pid2 and returns traditional
>       0,1,2 result for sorting purpose

That's quite a bit more code.  Is there a neat way of making it depend
on a new CONFIG_foo, then select CONFIG_foo if
CONFIG_CHECKPOINT_RESTORE?

  reply	other threads:[~2017-05-12 22:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24 15:39 Cyrill Gorcunov
2017-05-12 22:00 ` Andrew Morton [this message]
2017-05-12 22:14   ` Cyrill Gorcunov
2017-05-12 22:41 ` Jann Horn
2017-05-12 22:53   ` Cyrill Gorcunov
2017-05-13  1:45     ` Andrei Vagin
2017-05-13  6:55       ` Cyrill Gorcunov
2017-05-13  7:15         ` Cyrill Gorcunov
2017-09-17 16:01 ` [v4,resend,2/2] " Eugene Syromiatnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512150018.b931c7f5295dd7484845fcec@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=akpm@linuxfoundation.org \
    --cc=avagin@openvz.org \
    --cc=avagin@virtuozzo.com \
    --cc=gorcunov@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=jbaron@akamai.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mtk.manpages@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®