From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758942AbdELVwA convert rfc822-to-8bit (ORCPT ); Fri, 12 May 2017 17:52:00 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50244 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758114AbdELVv6 (ORCPT ); Fri, 12 May 2017 17:51:58 -0400 Date: Fri, 12 May 2017 18:51:50 -0300 From: Mauro Carvalho Chehab To: Darren Hart Cc: linux-kernel@vger.kernel.org, Linux Doc Mailing List , Mauro Carvalho Chehab , Peter Zijlstra , Ingo Molnar , Thomas Gleixner Subject: Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST Message-ID: <20170512185150.5b48c5f6@vento.lan> In-Reply-To: <20170512164122.GA17235@fury> References: <20170512164122.GA17235@fury> Organization: Samsung X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 12 May 2017 09:41:22 -0700 Darren Hart escreveu: > On Fri, May 12, 2017 at 10:59:47AM -0300, Mauro Carvalho Chehab wrote: > > There are a few issues on some kernel-doc markups that was > > causing troubles with kernel-doc output on ReST format. > > Fix them. > > > > No functional changes. > > > > Signed-off-by: Mauro Carvalho Chehab > > No objection. One question, rather than prefixing the bulleted list of return > codes with a "-" which has no ReST meaning I could find, should we use "*" > instead which would be converted to a bullet it formatted documentation? At least on Sphinx[1]: "A text block which begins with a "*", "+", "-", "•", "‣", or "⁃", followed by whitespace, is a bullet list item" I never tried "+", but both "-" and "*" produce the same visual. [1] http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#bullet-lists > > > @@ -1259,9 +1259,9 @@ static int lock_pi_update_atomic(u32 __user *uaddr, u32 uval, u32 newval) > > * @set_waiters: force setting the FUTEX_WAITERS bit (1) or not (0) > > * > > * Return: > > - * 0 - ready to wait; > > - * 1 - acquired the lock; > > - * <0 - error > > + * - 0 - ready to wait; > > + * - 1 - acquired the lock; > > + * - <0 - error > > * > > e.g. > > * Return: > * * 0 - ready to wait > * * 1 - acquired the lock > * * <0 - error > > I'm fine with either though, just curious if this would be an improvement, or if > we have an established policy (which I didn't find in the docs on docs...). I prefer myself to use "-". IMHO, a dash is visually less polluted than an asterisk, when reading text files, but I guess this is a matter of taste. > Acked-by: Darren Hart (VMware) Thanks, Mauro