mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Kernel Hardening" <kernel-hardening@lists.openwall.com>,
	"Greg KH" <greg@kroah.com>,
	"Heiko Carstens" <heiko.carstens@de.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"David Howells" <dhowells@redhat.com>,
	"Dave Hansen" <dave.hansen@intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Pavel Tikhomirov" <ptikhomirov@virtuozzo.com>,
	linux-s390 <linux-s390@vger.kernel.org>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	"Will Deacon" <will.deacon@arm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"René Nyffenegger" <mail@renenyffenegger.ch>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
	"Rik van Riel" <riel@redhat.com>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Brian Gerst" <brgerst@gmail.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Andy Lutomirski" <luto@kernel.org>,
	"Josh Poimboeuf" <jpoimboe@redhat.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Linux API" <linux-api@vger.kernel.org>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Daniel Micay" <danielmicay@gmail.com>,
	"James Morse" <james.morse@arm.com>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Thomas Garnier" <thgarnie@google.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode
Date: Fri, 12 May 2017 21:21:06 +0100	[thread overview]
Message-ID: <20170512202106.GO22219@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAGXu5j+xmyJ6RhtPw9rUgs7k3sZ1KKWffvyGGG--oPfu9W42ng@mail.gmail.com>

On Fri, May 12, 2017 at 12:30:02PM -0700, Kees Cook wrote:
> I'm clearly not explaining things well enough. I shouldn't say
> "corruption", I should say "malicious manipulation". The methodology
> of attacks against the stack are quite different from the other kinds
> of attacks like use-after-free, heap overflow, etc. Being able to
> exhaust the kernel stack (either due to deep recursion or unbounded
> alloca())

I really hope we don't have alloca() use in the kernel.  Do you have
evidence to support that assertion?

IMHO alloca() (or similar) should not be present in any kernel code
because we have a limited stack - we have kmalloc() etc for that kind
of thing.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2017-05-12 20:21 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 15:32 Thomas Garnier
2017-04-28 15:32 ` [PATCH v9 2/4] x86/syscalls: Optimize address limit check Thomas Garnier
2017-04-28 15:32 ` [PATCH v9 3/4] arm/syscalls: " Thomas Garnier
2017-04-28 15:32 ` [PATCH v9 4/4] arm64/syscalls: " Thomas Garnier
2017-05-05 22:18 ` [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode Thomas Garnier
2017-05-08  7:33   ` Ingo Molnar
2017-05-08  7:52     ` Ingo Molnar
2017-05-08 15:22       ` [kernel-hardening] " Daniel Micay
2017-05-08 15:26         ` Kees Cook
2017-05-08 19:51           ` Thomas Garnier
2017-05-09  6:56           ` Ingo Molnar
2017-05-09 11:10             ` Greg KH
2017-05-09 14:29               ` Thomas Garnier
2017-05-11 23:17                 ` Thomas Garnier
2017-05-11 23:44                   ` Linus Torvalds
2017-05-12  5:28                     ` Martin Schwidefsky
2017-05-12  5:34                       ` Kees Cook
2017-05-12  5:54                         ` Martin Schwidefsky
2017-05-12 19:01                           ` Kees Cook
2017-05-12 19:08                             ` Russell King - ARM Linux
2017-05-12 19:08                             ` Linus Torvalds
2017-05-12 19:30                               ` Kees Cook
2017-05-12 20:21                                 ` Russell King - ARM Linux [this message]
2017-05-12 20:30                                   ` Peter Zijlstra
2017-05-12 20:45                                     ` Russell King - ARM Linux
2017-05-12 21:00                                       ` Kees Cook
2017-05-12 21:04                                         ` Kees Cook
2017-05-13  7:21                                     ` Christoph Hellwig
2017-05-12 21:06                                   ` Al Viro
2017-05-12 21:16                                     ` Daniel Micay
2017-05-12 21:17                                     ` Kees Cook
2017-05-12 21:23                                       ` Daniel Micay
2017-05-12 21:41                                       ` Al Viro
2017-05-12 21:47                                         ` Rik van Riel
2017-05-12 22:57                                           ` Al Viro
2017-05-12 21:50                                         ` Kees Cook
2017-05-12  6:57                         ` Ingo Molnar
2017-05-12  6:13                     ` Andy Lutomirski
2017-05-12  6:58                     ` Ingo Molnar
2017-05-12 17:05                       ` Thomas Garnier
2017-05-09 16:30             ` Kees Cook
2017-05-08 12:46     ` Greg KH
2017-05-09  6:45       ` Ingo Molnar
2017-05-09  8:56         ` Christoph Hellwig
2017-05-09 13:00           ` Andy Lutomirski
2017-05-09 13:02             ` Christoph Hellwig
2017-05-09 16:03               ` Christoph Hellwig
2017-05-09 16:50                 ` Kees Cook
2017-05-09 22:52                   ` Andy Lutomirski
2017-05-09 23:31                     ` Kees Cook
2017-05-10  1:59                       ` Andy Lutomirski
2017-05-10  7:15                       ` Christoph Hellwig
2017-05-11 11:22                       ` Borislav Petkov
2017-05-10  6:46                   ` Christoph Hellwig
2017-05-10  2:11                 ` Al Viro
2017-05-10  2:45                   ` Al Viro
2017-05-10  3:12                     ` Al Viro
2017-05-10  3:21                       ` Al Viro
2017-05-10  3:39                         ` Al Viro
2017-05-10  6:54                           ` Christoph Hellwig
2017-05-10  6:53                       ` Christoph Hellwig
2017-05-10  7:27                         ` Al Viro
2017-05-10  7:35                           ` Christoph Hellwig
2017-05-10  6:49                     ` Christoph Hellwig
2017-05-10  7:28                 ` Arnd Bergmann
2017-05-10  7:35                   ` Christoph Hellwig
2017-05-09 16:05             ` Brian Gerst
2017-05-10  7:37             ` Arnd Bergmann
2017-05-10  8:08               ` Al Viro
2017-05-10  8:14                 ` Christoph Hellwig
2017-05-11  0:18                   ` Andy Lutomirski
2017-05-12  7:00             ` Ingo Molnar
2017-05-12  7:15               ` Al Viro
2017-05-12  7:35                 ` Christoph Hellwig
2017-05-12  7:43                 ` Arnd Bergmann
2017-05-12  8:11                   ` Christoph Hellwig
2017-05-12  8:16                     ` Al Viro
2017-05-12  8:11                   ` Al Viro
2017-05-12  8:20                     ` Arnd Bergmann
2017-05-12 23:20                 ` Andy Lutomirski
2017-05-08 13:09     ` Kees Cook
2017-05-08 14:02       ` Ingo Molnar
2017-05-08 14:06         ` Jann Horn
2017-05-08 20:48           ` Al Viro
2017-05-12 23:15             ` Andy Lutomirski
2017-05-08 15:24         ` Kees Cook
2017-05-09  6:34           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512202106.GO22219@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=borntraeger@de.ibm.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=danielmicay@gmail.com \
    --cc=dave.hansen@intel.com \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=greg@kroah.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mail@renenyffenegger.ch \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=ptikhomirov@virtuozzo.com \
    --cc=riel@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®