mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: amir73il@gmail.com, Florian Fainelli <f.fainelli@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	linux-unionfs@vger.kernel.org (open list:OVERLAY FILESYSTEM)
Subject: [PATCH] ovl: Select EXPORTFS for exportfs_{en,de}code_fh
Date: Fri, 12 May 2017 19:17:57 -0700	[thread overview]
Message-ID: <20170513021757.2356-1-f.fainelli@gmail.com> (raw)

fs/overlayfs/namei.c now calls exportfs_decode_fh() and
fs/overlayfs/copy_up.c calls exportfs_encode_fh() but misses an EXPORTFS
select which results in the following build error:

fs/built-in.o: In function `ovl_get_origin':
/home/florian/dev/linux/fs/overlayfs/namei.c:141: undefined reference to
`exportfs_decode_fh'
fs/built-in.o: In function `ovl_encode_fh':
/home/florian/dev/linux/fs/overlayfs/copy_up.c:253: undefined reference
to `exportfs_encode_fh'
Makefile:997: recipe for target 'vmlinux' failed

Fixes: a9d019573e88 ("ovl: lookup non-dir copy-up-origin by file handle")
Fixes: 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 fs/overlayfs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/overlayfs/Kconfig b/fs/overlayfs/Kconfig
index 0daac5112f7a..c0c9683934b7 100644
--- a/fs/overlayfs/Kconfig
+++ b/fs/overlayfs/Kconfig
@@ -1,5 +1,6 @@
 config OVERLAY_FS
 	tristate "Overlay filesystem support"
+	select EXPORTFS
 	help
 	  An overlay filesystem combines two filesystems - an 'upper' filesystem
 	  and a 'lower' filesystem.  When a name exists in both filesystems, the
-- 
2.11.0

             reply	other threads:[~2017-05-13  2:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-13  2:17 Florian Fainelli [this message]
2017-05-13  6:37 ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170513021757.2356-1-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=amir73il@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®