From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758344AbdEMUtz (ORCPT ); Sat, 13 May 2017 16:49:55 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34181 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755425AbdEMUty (ORCPT ); Sat, 13 May 2017 16:49:54 -0400 From: Maksim Salau To: Heikki Krogerus , Juergen Stuber , Greg Kroah-Hartman , legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Alfredo Rafael Vicente Boix Cc: Maksim Salau Subject: [PATCH v2] usb: misc: legousbtower: Fix memory leak Date: Sat, 13 May 2017 23:49:26 +0300 Message-Id: <20170513204926.9089-1-maksim.salau@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org get_version_reply is not freed if function returns with success. Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack") Reported-by: Heikki Krogerus Signed-off-by: Maksim Salau --- v2: Changed tags to match guidelines. drivers/usb/misc/legousbtower.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index aa3c280fdf8d..0782ac6f5edf 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -926,6 +926,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device USB_MAJOR, dev->minor); exit: + kfree(get_version_reply); return retval; error: -- 2.9.3