From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759886AbdEOH4O (ORCPT ); Mon, 15 May 2017 03:56:14 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48532 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759863AbdEOH4M (ORCPT ); Mon, 15 May 2017 03:56:12 -0400 Date: Sun, 14 May 2017 19:11:15 +0900 From: Mark Brown To: Ryan Lee Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ryan.lee.maxim@gmail.com Message-ID: <20170514101115.f53hlcbp7z4muelu@sirena.org.uk> References: <1494006135-1178-1-git-send-email-ryans.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="52va3uy4twnioty7" Content-Disposition: inline In-Reply-To: <1494006135-1178-1-git-send-email-ryans.lee@maximintegrated.com> X-Cookie: Dealer prices may vary. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop tracking control X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --52va3uy4twnioty7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2017 at 10:42:15AM -0700, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- The subject line suggests that this is adding two new features. Unless they are very closely related in the code they should be submitted as separate patches as covered in SubmittingPatches. > default: > - dev_err(codec->dev, "DAI clock mode unsupported"); > + dev_err(codec->dev, "DAI clock mode unsupported\n"); > return -EINVAL; > } > =20 It also seems like there are a number of unrelated stylistic changes in this patch. While it's fine to make such changes they too should be in separate patches. --52va3uy4twnioty7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlkYLUMACgkQJNaLcl1U h9Cqqgf/YjlhSOcuvG0d1rGFO9ghHZio4yTHLTNRcqWJ2vFgCAUR3XSXul79gZMu f/1bZUh+dUMAKJg3TmRE23A0l5Xg4bJIc8a8BSzHCij/xsgQz/jkapD1GOhiOk2V mgy93DfSSU+iudZUjz3sKazjBc09LIx2s3AXKlV8vgKEMIL3plA5d+xONOFwpK8Q 4epFmHpBySn+BAWUdqms8E4qhLkz+x37X1jxlq01OfsYmRevxVjtdgv9eSwoPk3M OsgDO/70JT227eanuECAGNKFtWqd2uyj2wP0VebekH/kYdMtGJ8yA7b6Jwu8TWd/ fkFhywrfhlodLjxRf5clqXVEIVfdlQ== =sVeo -----END PGP SIGNATURE----- --52va3uy4twnioty7--