From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759989AbdEOH52 (ORCPT ); Mon, 15 May 2017 03:57:28 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48698 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759508AbdEOH5N (ORCPT ); Mon, 15 May 2017 03:57:13 -0400 Date: Sun, 14 May 2017 19:13:23 +0900 From: Mark Brown To: Julia Lawall Cc: Tony Lindgren , keescook@chromium.org, kernel-janitors@vger.kernel.org, Liam Girdwood , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20170514101323.235p6jflfproucmv@sirena.org.uk> References: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr> <1493928654-18768-7-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7umbma5pm3ap6xio" Content-Disposition: inline In-Reply-To: <1493928654-18768-7-git-send-email-Julia.Lawall@lip6.fr> X-Cookie: Dealer prices may vary. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7umbma5pm3ap6xio Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 04, 2017 at 10:10:51PM +0200, Julia Lawall wrote: > Drop static on a local variable, when the variable is initialized before > any use, on every possible execution path through the function. When sending a bunch of changes like this please either send the cover letter to everyone or send each patch separately (this seems like it stands alone just fine). The first question when only one patch in a series is visible is always what are the interdependencies. --7umbma5pm3ap6xio Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlkYLcIACgkQJNaLcl1U h9BsWgf8DkF8kyGJlAqKsU2kTDfRZeovyuQK4RK8YZtgrZRlXC/cLnObCQMpTpiu JtvnmRk3gNvG/klpdXOJfEEIkBk9KsEjYJ0XrUHqWsXjUy898O0OkwaD9wAc3FWk ne0QSmaAcMJyqzuz79UORRvPoac/wSB8S7rOyAfO/qbTQ/k4hlpRwbirexkaFqCQ g8cX2gcnrIEuTP2S1tYnUCSeAzlFrykFe47oG2MUCoue5QNmXc/D2G26jPs0loxN FpI2lQG/KF6psXYxaJ3Ah9yla+B3SqrJ/wWz+fr9ZXaXoLkyWf4QFStCmJnnj7Cm PsZaG1FjwFqarz3KQ9kvU/jiBJQ0tg== =0afU -----END PGP SIGNATURE----- --7umbma5pm3ap6xio--