From: Icenowy Zheng <icenowy@aosc.io>
To: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sunxi@googlegroups.com, Icenowy Zheng <icenowy@aosc.io>
Subject: [PATCH v7 06/13] drm/sun4i: add a dedicated module for sun4i-backend and sun4i-layer
Date: Mon, 15 May 2017 00:30:38 +0800 [thread overview]
Message-ID: <20170514163045.40366-7-icenowy@aosc.io> (raw)
In-Reply-To: <20170514163045.40366-1-icenowy@aosc.io>
Currently the direct call from CRTC code to layer code has disappeared,
instead the layer's init function is called via the backend's ops.
Add a dedicated module for sun4i-backend and sun4i-layer, and drop the
EXPORT_SYMBOL from backend code to layer code.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
---
Changes in v7:
- Added Chen-Yu's Reviewed-by.
drivers/gpu/drm/sun4i/Makefile | 5 +++--
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ----
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/Makefile b/drivers/gpu/drm/sun4i/Makefile
index 59b757350a1f..a251fb36c951 100644
--- a/drivers/gpu/drm/sun4i/Makefile
+++ b/drivers/gpu/drm/sun4i/Makefile
@@ -5,9 +5,10 @@ sun4i-tcon-y += sun4i_tcon.o
sun4i-tcon-y += sun4i_rgb.o
sun4i-tcon-y += sun4i_dotclock.o
sun4i-tcon-y += sun4i_crtc.o
-sun4i-tcon-y += sun4i_layer.o
+
+sun4i-backend-y += sun4i_backend.o sun4i_layer.o
obj-$(CONFIG_DRM_SUN4I) += sun4i-drm.o sun4i-tcon.o
-obj-$(CONFIG_DRM_SUN4I) += sun4i_backend.o
+obj-$(CONFIG_DRM_SUN4I) += sun4i-backend.o
obj-$(CONFIG_DRM_SUN4I) += sun6i_drc.o
obj-$(CONFIG_DRM_SUN4I) += sun4i_tv.o
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 611cdcb9c182..fac1a414ba49 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -83,7 +83,6 @@ void sun4i_backend_layer_enable(struct sun4i_backend *backend,
regmap_update_bits(backend->engine.regs, SUN4I_BACKEND_MODCTL_REG,
SUN4I_BACKEND_MODCTL_LAY_EN(layer), val);
}
-EXPORT_SYMBOL(sun4i_backend_layer_enable);
static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
u32 format, u32 *mode)
@@ -170,7 +169,6 @@ int sun4i_backend_update_layer_coord(struct sun4i_backend *backend,
return 0;
}
-EXPORT_SYMBOL(sun4i_backend_update_layer_coord);
int sun4i_backend_update_layer_formats(struct sun4i_backend *backend,
int layer, struct drm_plane *plane)
@@ -205,7 +203,6 @@ int sun4i_backend_update_layer_formats(struct sun4i_backend *backend,
return 0;
}
-EXPORT_SYMBOL(sun4i_backend_update_layer_formats);
int sun4i_backend_update_layer_buffer(struct sun4i_backend *backend,
int layer, struct drm_plane *plane)
@@ -246,7 +243,6 @@ int sun4i_backend_update_layer_buffer(struct sun4i_backend *backend,
return 0;
}
-EXPORT_SYMBOL(sun4i_backend_update_layer_buffer);
static int sun4i_backend_init_sat(struct device *dev) {
struct sun4i_backend *backend = dev_get_drvdata(dev);
--
2.12.2
next prev parent reply other threads:[~2017-05-14 16:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-14 16:30 [PATCH v7 00/13] Initial Allwinner Display Engine 2.0 Support Icenowy Zheng
2017-05-14 16:30 ` [PATCH v7 01/13] dt-bindings: add binding for the Allwinner DE2 CCU Icenowy Zheng
2017-05-15 8:40 ` Maxime Ripard
2017-05-14 16:30 ` [PATCH v7 02/13] clk: sunxi-ng: add support for " Icenowy Zheng
2017-05-15 8:40 ` Maxime Ripard
2017-05-14 16:30 ` [PATCH v7 03/13] dt-bindings: add bindings for DE2 on V3s SoC Icenowy Zheng
2017-05-15 9:24 ` Maxime Ripard
2017-05-14 16:30 ` [PATCH v7 04/13] drm/sun4i: return only planes for layers created Icenowy Zheng
2017-05-15 9:24 ` Maxime Ripard
2017-05-14 16:30 ` [PATCH v7 05/13] drm/sun4i: abstract a engine type Icenowy Zheng
2017-05-15 9:20 ` Maxime Ripard
2017-05-15 9:35 ` [linux-sunxi] " Icenowy Zheng
2017-05-16 12:14 ` Maxime Ripard
2017-05-14 16:30 ` Icenowy Zheng [this message]
2017-05-14 16:30 ` [PATCH v7 07/13] drm/sun4i: add a Kconfig option for sun4i-backend Icenowy Zheng
2017-05-14 16:30 ` [PATCH v7 08/13] drm/sun4i: add support for Allwinner DE2 mixers Icenowy Zheng
2017-05-14 16:30 ` [PATCH v7 09/13] drm/sun4i: Add compatible string for V3s display engine Icenowy Zheng
2017-05-14 16:30 ` [PATCH v7 10/13] drm/sun4i: tcon: add support for V3s TCON Icenowy Zheng
2017-05-14 16:30 ` [PATCH v7 11/13] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Icenowy Zheng
2017-05-15 9:24 ` Maxime Ripard
2017-05-17 9:27 ` icenowy
2017-05-17 9:32 ` icenowy
2017-05-14 16:30 ` [PATCH v7 12/13] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC Icenowy Zheng
2017-05-14 16:30 ` [PATCH v7 13/13] [DO NOT MERGE] ARM: sun8i: v3s: enable LCD panel of Lichee Pi Zero Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170514163045.40366-7-icenowy@aosc.io \
--to=icenowy@aosc.io \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®