From: David Miller <davem@davemloft.net>
To: gregkh@linuxfoundation.org
Cc: ebiederm@xmission.com, mahesh@bandewar.net, mingo@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
keescook@chromium.org, edumazet@google.com, maheshb@google.com
Subject: Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE
Date: Mon, 15 May 2017 09:52:28 -0400 (EDT) [thread overview]
Message-ID: <20170515.095228.1483686375235860235.davem@davemloft.net> (raw)
In-Reply-To: <20170515061059.GB28741@kroah.com>
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Mon, 15 May 2017 08:10:59 +0200
> On Sun, May 14, 2017 at 08:57:34AM -0500, Eric W. Biederman wrote:
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>>
>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
>> index bcb0f610ee42..6b72528a4636 100644
>> --- a/net/core/rtnetlink.c
>> +++ b/net/core/rtnetlink.c
>> @@ -2595,7 +2595,7 @@ static int rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
>>
>> if (!ops) {
>> #ifdef CONFIG_MODULES
>> - if (kind[0]) {
>> + if (kind[0] && capable(CAP_NET_ADMIN)) {
>> __rtnl_unlock();
>> request_module("rtnl-link-%s", kind);
>> rtnl_lock();
>
> I don't object to this if the networking developers don't mind the
> change in functionality. They can handle the fallout :)
As I've said in another email, I am pretty sure this can break things.
next prev parent reply other threads:[~2017-05-15 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 23:22 Mahesh Bandewar
2017-05-14 10:45 ` Greg Kroah-Hartman
2017-05-14 13:57 ` Eric W. Biederman
2017-05-15 6:10 ` Greg Kroah-Hartman
2017-05-15 13:52 ` David Miller [this message]
2017-05-15 17:59 ` Mahesh Bandewar (महेश बंडेवार)
2017-05-15 18:14 ` David Miller
2017-05-15 18:20 ` Eric W. Biederman
2017-05-15 19:59 ` Florian Westphal
2017-05-15 2:42 ` Mahesh Bandewar (महेश बंडेवार)
2017-05-15 6:10 ` Greg Kroah-Hartman
2017-05-15 13:12 ` Eric Dumazet
2017-05-15 17:07 ` Kees Cook
2017-05-15 13:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515.095228.1483686375235860235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®