From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759911AbdEOIIg (ORCPT ); Mon, 15 May 2017 04:08:36 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:44129 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759877AbdEOIIe (ORCPT ); Mon, 15 May 2017 04:08:34 -0400 From: Stefan Agner To: broonie@kernel.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Stefan Agner Subject: [PATCH] regmap: add regmap_debugfs_exit as devres action Date: Mon, 15 May 2017 01:08:27 -0700 Message-Id: <20170515080827.22905-1-stefan@agner.ch> X-Mailer: git-send-email 2.13.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of manually cleanup regmap_debugfs_exit, use devres action to do the cleanup. This also works for external users of regmap_attach_dev. Signed-off-by: Stefan Agner --- The cast is not that pretty, but I found it better than making regmap_debugfs_exit type unsafe... This fixes warnings when reloading certain drivers making use of regmap_debugfs_exit: imx7d-pinctrl 30330000.iomuxc: Failed to create debugfs directory -- Stefan drivers/base/regmap/regmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index b9a779a4a739..0e32e0e2f00a 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -528,6 +528,7 @@ int regmap_attach_dev(struct device *dev, struct regmap *map, return -ENOMEM; } *m = map; + devm_add_action(dev, (void (*)(void *))regmap_debugfs_exit, map); devres_add(dev, m); return 0; @@ -1215,7 +1216,6 @@ void regmap_exit(struct regmap *map) struct regmap_async *async; regcache_exit(map); - regmap_debugfs_exit(map); regmap_range_exit(map); if (map->bus && map->bus->free_context) map->bus->free_context(map->bus_context); -- 2.13.0