From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760178AbdEOIoY (ORCPT ); Mon, 15 May 2017 04:44:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41128 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbdEOIoX (ORCPT ); Mon, 15 May 2017 04:44:23 -0400 Date: Mon, 15 May 2017 11:44:04 +0300 From: Dan Carpenter To: Haim Daniel Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/staging: refactor dgnc tty registration. Message-ID: <20170515084404.2j62oyyoxn5nc55v@mwanda> References: <1494777024-20141-1-git-send-email-haimdaniel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494777024-20141-1-git-send-email-haimdaniel@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2017 at 06:50:24PM +0300, Haim Daniel wrote: > @@ -129,6 +113,41 @@ static void dgnc_tty_set_termios(struct tty_struct *tty, > > /* TTY Initialization/Cleanup Functions */ > > +static struct tty_driver *__dgnc_tty_register(char *serial_name, uint maxports, No need for double underscores. > + int major, int minor) > +{ > + int rc; > + struct tty_driver *drv = tty_alloc_driver(maxports, > + TTY_DRIVER_REAL_RAW | > + TTY_DRIVER_DYNAMIC_DEV | > + TTY_DRIVER_HARDWARE_BREAK); > + if (IS_ERR(drv)) > + return drv; Blank line between declaration and code. Do it like this: struct tty_driver *drv; int rc; drv = tty_alloc_driver(maxports, TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV | TTY_DRIVER_HARDWARE_BREAK); if (IS_ERR(drv)) return drv; Also create a matching dgnc_tty_unregister function that does: static void dgnc_tty_unregister(struct tty_driver *drv) { tty_unregister_driver(drv); put_tty_driver(drv); } regards, dan carpenter