From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934268AbdEOKVz (ORCPT ); Mon, 15 May 2017 06:21:55 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38303 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933178AbdEOKVv (ORCPT ); Mon, 15 May 2017 06:21:51 -0400 X-ME-Sender: X-Sasl-enc: KPejlL/ZlERtLQiFAu8j/KE9uHW0dYZ5DoT4yThhkgl8 1494843705 Date: Mon, 15 May 2017 12:21:38 +0200 From: Greg KH To: Matej Dujava Cc: Sudip Mukherjee , Teddy Wang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/9] staging: sm750fb: removing unnecessary binary operations Message-ID: <20170515102138.GB31131@kroah.com> References: <1494715362-5545-1-git-send-email-mdujava@kocurkovo.cz> <1494715362-5545-5-git-send-email-mdujava@kocurkovo.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494715362-5545-5-git-send-email-mdujava@kocurkovo.cz> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2017 at 12:42:37AM +0200, Matej Dujava wrote: > This patch remove unnecessary operation (eg. ``X | (0x0 << Y)`` to ``X``). > > Signed-off-by: Matej Dujava > --- > drivers/staging/sm750fb/ddk750_display.h | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h > index cef7f46..f9e1614 100644 > --- a/drivers/staging/sm750fb/ddk750_display.h > +++ b/drivers/staging/sm750fb/ddk750_display.h > @@ -9,8 +9,8 @@ > #define PNL_2_OFFSET 0 > #define PNL_2_MASK (3 << PNL_2_OFFSET) > #define PNL_2_USAGE (PNL_2_MASK << 16) > -#define PNL_2_PRI ((0 << PNL_2_OFFSET) | PNL_2_USAGE) > -#define PNL_2_SEC ((2 << PNL_2_OFFSET) | PNL_2_USAGE) > +#define PNL_2_PRI (PNL_2_USAGE) > +#define PNL_2_SEC (PNL_2_USAGE | (2 << PNL_2_OFFSET)) But the original makes more sense to read, don't you think so? thanks, greg k-h