From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166AbdEOKxb (ORCPT ); Mon, 15 May 2017 06:53:31 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50218 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755183AbdEOKx3 (ORCPT ); Mon, 15 May 2017 06:53:29 -0400 Date: Mon, 15 May 2017 11:53:19 +0100 From: Mark Brown To: Geert Uytterhoeven Cc: Vignesh R , linux-spi , "linux-kernel@vger.kernel.org" Message-ID: <20170515105319.5vm46modegh3gfke@sirena.org.uk> References: <1493883438-19462-1-git-send-email-geert@linux-m68k.org> <20170514095020.roqoeohylvrgoad7@sirena.org.uk> <20170515101235.uy776lopdsyd4h73@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oena2zzbyvehanrw" Content-Disposition: inline In-Reply-To: X-Cookie: Never give an inch! User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oena2zzbyvehanrw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 15, 2017 at 12:21:33PM +0200, Geert Uytterhoeven wrote: > On Mon, May 15, 2017 at 12:12 PM, Mark Brown wrote: > > No, I was thinking more just not needing the dependency at all. > Then what's the point of the existence of COMPILE_TEST? > We can just have stubs for everything, and always build everything. It's useful for platform specific devices (like this one should be) but having to add dependencies for basic kernel APIs like the DMA one is just making for a lot of noise. There's plenty of platforms without DMA that also have no real use for this driver, it's not really a relevant thing when deciding if the driver might be useful if what you're trying to do is hide drivers that aren't useful on the platform. --oena2zzbyvehanrw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlkZiJ4ACgkQJNaLcl1U h9Ds2Af/QX2ralGx2fjEH+tnbq8kRgkp71sS7kdbS/pi4Jhdux5a4zoSfqOc74a8 qxxsxQe3yBnY/Yzbp1gUFHlCNyTmcz3MY5p3MfMTpM+dJ45/4E4/NPwAVsTtbB3U S595rMhfjFJmTUyiqSmIxZWAPITGqqs+oVDgc+FLGoN7ncgR2NyFmzKua8LG6exV 0XQrZxGdlED3DYp82DJGIIt2fv8qS6NEuHP9oaNLk5AOFl13s3SDsHFR3neyP4wB PfMlJax1QzsSwA8vrLYrDW8YNFwGkzd5AxRZ5+Mef8KaxFQrIhRtER0rMG+KcCLf uowM64sRt0cmWFX+kK+IQ0be/W3jXQ== =nZ9i -----END PGP SIGNATURE----- --oena2zzbyvehanrw--