From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934738AbdEOPNB (ORCPT ); Mon, 15 May 2017 11:13:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:60700 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933381AbdEOPNA (ORCPT ); Mon, 15 May 2017 11:13:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 830B7239BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 15 May 2017 11:12:57 -0400 From: Steven Rostedt To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Ingo Molnar , Mark Rutland Subject: Re: [patch 18/18] sched: Enable smp_processor_id() checks early Message-ID: <20170515111257.0a9b1c46@gandalf.local.home> In-Reply-To: <20170514183613.926588875@linutronix.de> References: <20170514182716.347236777@linutronix.de> <20170514183613.926588875@linutronix.de> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 14 May 2017 20:27:34 +0200 Thomas Gleixner wrote: > smp_processor_id() checks are enabled after the boot process is done. That > hides bugs in the smp bringup and driver initialization code. > > Enable it right before the first non-boot CPU is brought up. > > Signed-off-by: Thomas Gleixner > --- > init/main.c | 3 +++ > lib/smp_processor_id.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > > Signed-off-by: Thomas Gleixner > --- > init/main.c | 3 +++ > lib/smp_processor_id.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > --- a/init/main.c > +++ b/init/main.c > @@ -1025,6 +1025,9 @@ static noinline void __init kernel_init_ > */ > set_cpus_allowed_ptr(current, cpumask_of(raw_smp_processor_id())); > > + /* Enable smp_processor_id() checks */ > + system_state = SYSTEM_BOOTING_SMP; > + Just a nit, but why set this here and not just before smp_prepare_cpus()? Anyway... Reviewed-by: Steven Rostedt (VMware) -- Steve > cad_pid = task_pid(current); > > smp_prepare_cpus(setup_max_cpus); > --- a/lib/smp_processor_id.c > +++ b/lib/smp_processor_id.c > @@ -28,7 +28,7 @@ notrace static unsigned int check_preemp > /* > * It is valid to assume CPU-locality during early bootup: > */ > - if (system_state != SYSTEM_RUNNING) > + if (system_state < SYSTEM_BOOTING_SMP) > goto out; > > /* >