From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964854AbdEONof (ORCPT ); Mon, 15 May 2017 09:44:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42396 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934063AbdEONod (ORCPT ); Mon, 15 May 2017 09:44:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D94BD13A68 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=none smtp.mailfrom=sd@queasysnail.net DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D94BD13A68 Date: Mon, 15 May 2017 15:44:26 +0200 From: Sabrina Dubroca To: Dave Young Cc: Ard Biesheuvel , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , linux-efi@vger.kernel.org, Matt Fleming , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org Subject: Re: [PATCH 08/10] efi/x86: Move EFI BGRT init code to early init code Message-ID: <20170515134426.GC1068@bistromath.localdomain> References: <1485868902-20401-1-git-send-email-ard.biesheuvel@linaro.org> <1485868902-20401-9-git-send-email-ard.biesheuvel@linaro.org> <20170513231827.GA1068@bistromath.localdomain> <20170515083740.GA30363@dhcp-128-65.nay.redhat.com> <20170515111037.GB1068@bistromath.localdomain> <20170515131835.GA5708@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170515131835.GA5708@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.8.2 (2017-04-18) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 15 May 2017 13:44:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-05-15, 21:18:35 +0800, Dave Young wrote: > On 05/15/17 at 01:10pm, Sabrina Dubroca wrote: > > 2017-05-15, 16:37:40 +0800, Dave Young wrote: > > > diff --git a/arch/x86/platform/efi/efi-bgrt.c b/arch/x86/platform/efi/efi-bgrt.c > > > index 04ca876..b986e26 100644 > > > --- a/arch/x86/platform/efi/efi-bgrt.c > > > +++ b/arch/x86/platform/efi/efi-bgrt.c > > > @@ -36,6 +36,9 @@ void __init efi_bgrt_init(struct acpi_table_header *table) > > > if (acpi_disabled) > > > return; > > > > > > + if (!efi_enabled(EFI_CONFIG_TABLES)) > > A better version should be checking EFI_BOOT, could you retest with > below instead? If it works I can send a patch with your Tested-by: > if (!efi_enabled(EFI_BOOT)) Yes, that works. Thanks for the fix :) > > > + return; > > > + > > > if (table->length < sizeof(bgrt_tab)) { > > > pr_notice("Ignoring BGRT: invalid length %u (expected %zu)\n", > > > table->length, sizeof(bgrt_tab)); > > > > > > > -- > > Sabrina > > Thanks > Dave -- Sabrina