From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757827AbdEOPu3 (ORCPT ); Mon, 15 May 2017 11:50:29 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24923 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbdEOPu0 (ORCPT ); Mon, 15 May 2017 11:50:26 -0400 Date: Mon, 15 May 2017 08:50:12 -0700 From: "Darrick J. Wong" To: Arnd Bergmann Cc: Dan Williams , Jan Kara , Geert Uytterhoeven , linux-xfs@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] dax: hide block device code in #ifdef Message-ID: <20170515155012.GM4519@birch.djwong.org> References: <20170515134508.2713243-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 04:20:09PM +0200, Arnd Bergmann wrote: > On Mon, May 15, 2017 at 4:11 PM, Dan Williams wrote: > > On Mon, May 15, 2017 at 6:44 AM, Arnd Bergmann wrote: > >> We allow configurations with CONFIG_BLOCK=n and CONFIG_DAX=y, which now > >> results in a link error: > >> > >> drivers/dax/super.c: In function 'bdev_dax_pgoff': > >> drivers/dax/super.c:50:26: error: implicit declaration of function 'get_start_sect'; did you mean 'get_task_cred'? [-Werror=implicit-function-declaration] > >> > >> The two obvious ways to avoid the link error are to either add an #ifdef > >> around the code that was moved from fs/block_dev.c, or to disallow the > >> configuration. I could not see if there is or is not a reason to support > >> this combination of options, but in case there is, the #ifdef is the > >> safer choice. > >> > >> Fixes: ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX") > >> Signed-off-by: Arnd Bergmann > > > > Yup, the same one I came up with: > > > > https://patchwork.kernel.org/patch/9725513/ > > > > If you have a a pull request coming up soon you can add my Acked-by to > > both of these patches, otherwise I'll send what I have along at the > > end of the week. > > I didn't plan to send a pull request, please use whatever you have. I don't mind pulling the (second) patch in via the xfs tree. Reviewed-by: Darrick J. Wong --D > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html