From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: sgruszka@redhat.com, arnd@arndb.de, helmut.schaa@googlemail.com,
kvalo@codeaurora.org, daniel@makrotopia.org, dev@kresin.me,
pozega.tomislav@gmail.com, vasilugin@yandex.ru, roman@advem.lv,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rt2x00: improve calling conventions for register accessors
Date: Tue, 16 May 2017 11:37:23 -0400 (EDT) [thread overview]
Message-ID: <20170516.113723.631618367518477483.davem@davemloft.net> (raw)
In-Reply-To: <1494935936.15923.0.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 16 May 2017 13:58:56 +0200
> On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote:
>>
>> In rt2x00 driver we use poor convention in other kind of registers
>> accessors like bbp, mac, eeprom. I dislike to changing only rfcsr
>> accessors and leaving others in the old way. And changing all
>> accessors would be massive and error prone change, which I'm not
>> prefer either.
>
> That's a stupid argument, but for the sake of it - the conversion can
> easily be done with coccinelle/spatch without being "error prone".
Agreed, we have tools for this.
next prev parent reply other threads:[~2017-05-16 15:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 13:46 Arnd Bergmann
2017-05-15 14:28 ` Stanislaw Gruszka
2017-05-15 14:36 ` Arnd Bergmann
2017-05-15 14:40 ` David Miller
2017-05-15 19:02 ` Daniel Golle
2017-05-15 14:39 ` David Miller
2017-05-16 11:55 ` Stanislaw Gruszka
2017-05-16 11:58 ` Johannes Berg
2017-05-16 12:43 ` Stanislaw Gruszka
2017-05-16 15:37 ` David Miller [this message]
2017-05-16 13:44 ` Jes Sorensen
2017-05-16 14:19 ` Arnd Bergmann
2017-05-16 14:31 ` Jes Sorensen
[not found] ` <CAKR_QVKYpcficnx5G5NdLKh7xa9S18udYQNXDQ=LmfG=Qeapbg@mail.gmail.com>
2017-05-17 14:48 ` Arnd Bergmann
2017-05-16 14:23 ` Stanislaw Gruszka
2017-05-16 15:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516.113723.631618367518477483.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
--cc=roman@advem.lv \
--cc=sgruszka@redhat.com \
--cc=vasilugin@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®