From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbdEPHvg (ORCPT ); Tue, 16 May 2017 03:51:36 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27039 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdEPHvf (ORCPT ); Tue, 16 May 2017 03:51:35 -0400 Date: Tue, 16 May 2017 10:51:21 +0300 From: Dan Carpenter To: Haim Daniel Cc: devel@driverdev.osuosl.org, lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v3] drivers/staging: refactor dgnc tty registration. Message-ID: <20170516075120.sponc2rkyoxfz5mn@mwanda> References: <20170515115841.33uyk5xx26a773g7@mwanda> <1494851450-29629-1-git-send-email-haimdaniel@gmail.com> <20170515125252.2u6fqqfupoixbsui@mwanda> <9efb4f29-5097-91bd-8aba-7fd247f65a5c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9efb4f29-5097-91bd-8aba-7fd247f65a5c@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 04:49:16PM +0300, Haim Daniel wrote: > me@haim-toshiba1 ~ $ dpkg -l sparse > Desired=Unknown/Install/Remove/Purge/Hold > | > Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend > |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) > ||/ Name Version Architecture Description > +++-=================-=============-=============-======================================== > ii sparse 0.4.5~rc1-1 amd64 semantic parser of source > files > > me@haim-toshiba1 linux (next-20170512) $ make clean M=drivers/staging > /dgnc/; make C=1 M=drivers/staging/dgnc/ > > drivers/staging/dgnc/dgnc_tty.c:66:25: warning: too long initializer-string > for array of char > I downloaded the latest Sparse and don't see that warning. But GCC has a warning like that so I think this is really a GCC warning. It doesn't trigger for me, and with my config it's in fact, not a bug. The buffer is 19 characters and INIT_C_CC is 17 chars plus 1 NUL terminator. All these things are generic termios defines so I'm not even sure how you're triggering the warning. Anyway, your patch is harmless enough. regards, dan carpenter