From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbdEPHyw (ORCPT ); Tue, 16 May 2017 03:54:52 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28495 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbdEPHyu (ORCPT ); Tue, 16 May 2017 03:54:50 -0400 Date: Tue, 16 May 2017 10:54:21 +0300 From: Dan Carpenter To: Haim Daniel Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] drivers/staging: refactor dgnc tty registration. Message-ID: <20170516075421.cjqaw67nnmwithjx@mwanda> References: <20170515125252.2u6fqqfupoixbsui@mwanda> <1494857418-7713-1-git-send-email-haimdaniel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494857418-7713-1-git-send-email-haimdaniel@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 05:10:18PM +0300, Haim Daniel wrote: > -remove duplicate tty allocation code for serial and printer drivers. > -add missing tty c_ispeed and c_ospeed initialization to 9600. > -fix sparse warning: too long initializer-string for array of char. This is a GCC warning and not a Sparse warning. I still have no idea how it's getting triggered. But otherwise I have reviewed the patch and it's a nice clean up. regards, dan carpenter