From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbdEPMLQ (ORCPT ); Tue, 16 May 2017 08:11:16 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:36802 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbdEPMLO (ORCPT ); Tue, 16 May 2017 08:11:14 -0400 Date: Tue, 16 May 2017 05:11:12 -0700 From: Christoph Hellwig To: Gabriele Paoloni Cc: bhelgaas@google.com, helgaas@kernel.org, linuxarm@huawei.com, linux-pci@vger.kernel.org, lukas@wunner.de, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com Subject: Re: [PATCH 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service Message-ID: <20170516121112.GA16209@infradead.org> References: <1494930342-7132-1-git-send-email-gabriele.paoloni@huawei.com> <1494930342-7132-3-git-send-email-gabriele.paoloni@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494930342-7132-3-git-send-email-gabriele.paoloni@huawei.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + * pci_irq_vector() below is able to handle entry differently > + * depending on MSI vs MSI-x case > + * No need to mention that for every users. Except for that this looks fine: Reviewed-by: Christoph Hellwig