From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [patch V2 07/17] ACPI: Adjust system_state check
Date: Tue, 16 May 2017 15:07:54 -0400 [thread overview]
Message-ID: <20170516150754.783509f4@gandalf.local.home> (raw)
In-Reply-To: <20170516184735.446455652@linutronix.de>
On Tue, 16 May 2017 20:42:38 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:
> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
>
> Make the decision whether a pci root is hotplugged depend on SYSTEM_RUNNING
> instead of !SYSTEM_BOOTING. It makes no sense to cover states greater than
> SYSTEM_RUNNING as there are not hotplug events on reboot and poweroff.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> ---
> drivers/acpi/pci_root.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -523,7 +523,7 @@ static int acpi_pci_root_add(struct acpi
> struct acpi_pci_root *root;
> acpi_handle handle = device->handle;
> int no_aspm = 0;
> - bool hotadd = system_state != SYSTEM_BOOTING;
> + bool hotadd = system_state == SYSTEM_RUNNING;
>
> root = kzalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
> if (!root)
>
next prev parent reply other threads:[~2017-05-16 19:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 18:42 [patch V2 00/17] init: Enable might_sleep() and smp_processor_id() debugging early Thomas Gleixner
2017-05-16 18:42 ` [patch V2 01/17] init: Pin init task to boot cpu initially Thomas Gleixner
2017-05-16 19:06 ` Steven Rostedt
2017-05-23 8:47 ` [tip:sched/core] init: Pin init task to the boot CPU, initially tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 02/17] arm: Adjust system_state check Thomas Gleixner
2017-05-23 8:48 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 03/17] arm64: " Thomas Gleixner
2017-05-17 10:09 ` Mark Rutland
2017-05-17 14:23 ` Catalin Marinas
2017-05-23 8:48 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 04/17] x86/smp: " Thomas Gleixner
2017-05-23 8:49 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 05/17] metag: " Thomas Gleixner
2017-05-23 8:50 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 06/17] powerpc: " Thomas Gleixner
2017-05-23 8:50 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 07/17] ACPI: " Thomas Gleixner
2017-05-16 19:07 ` Steven Rostedt [this message]
2017-05-23 8:51 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 08/17] mm: " Thomas Gleixner
2017-05-23 8:51 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 09/17] cpufreq/pasemi: " Thomas Gleixner
2017-05-23 8:52 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 10/17] iommu/vt-d: Adjust system_state checks Thomas Gleixner
2017-05-23 8:52 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 11/17] iommu/of: Adjust system_state check Thomas Gleixner
2017-05-23 8:53 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 12/17] async: Adjust system_state checks Thomas Gleixner
2017-05-23 8:53 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 13/17] extable: " Thomas Gleixner
2017-05-23 8:54 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 14/17] printk: " Thomas Gleixner
2017-05-23 8:55 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 15/17] mm/vmscan: " Thomas Gleixner
2017-05-17 6:56 ` Vlastimil Babka
2017-05-23 8:55 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 16/17] init: Introduce SYSTEM_SCHEDULING state Thomas Gleixner
2017-05-17 10:58 ` Mark Rutland
2017-05-17 21:15 ` Boris Ostrovsky
2017-05-23 8:56 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early Thomas Gleixner
2017-05-16 19:12 ` Steven Rostedt
2017-05-16 22:46 ` Thomas Gleixner
2017-05-16 22:50 ` Steven Rostedt
2017-05-17 11:02 ` Mark Rutland
2017-05-23 8:56 ` [tip:sched/core] sched/core: " tip-bot for Thomas Gleixner
2017-05-17 10:58 ` [patch V2 00/17] init: Enable might_sleep() and smp_processor_id() debugging early Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516150754.783509f4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®