From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709AbdEQEex (ORCPT ); Wed, 17 May 2017 00:34:53 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:36832 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbdEQEet (ORCPT ); Wed, 17 May 2017 00:34:49 -0400 Date: Wed, 17 May 2017 10:04:45 +0530 From: Viresh Kumar To: Arvind Yadav Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] cpufreq: kirkwood-cpufreq:- Handle return value of clk_prepare_enable Message-ID: <20170517043445.GZ17481@vireshk-i7> References: <1494918717-16434-1-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494918717-16434-1-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-05-17, 12:41, Arvind Yadav wrote: > Here, Clock enable can failed. So adding an error check for > clk_prepare_enable. Rewrite it as: clk_prepare_enable() can fail here and we must check its return value. > Signed-off-by: Arvind Yadav > --- > drivers/cpufreq/kirkwood-cpufreq.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c > index 1b9bcd7..4c30103 100644 > --- a/drivers/cpufreq/kirkwood-cpufreq.c > +++ b/drivers/cpufreq/kirkwood-cpufreq.c > @@ -127,7 +127,12 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) > return PTR_ERR(priv.cpu_clk); > } > > - clk_prepare_enable(priv.cpu_clk); > + err = clk_prepare_enable(priv.cpu_clk); > + if (err) { > + dev_err(priv.dev, "Unable to prepare cpuclk\n"); > + return err; > + } > + > kirkwood_freq_table[0].frequency = clk_get_rate(priv.cpu_clk) / 1000; > > priv.ddr_clk = of_clk_get_by_name(np, "ddrclk"); > @@ -137,7 +142,11 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) > goto out_cpu; > } > > - clk_prepare_enable(priv.ddr_clk); > + err = clk_prepare_enable(priv.ddr_clk); > + if (err) { > + dev_err(priv.dev, "Unable to prepare ddrclk\n"); > + goto out_cpu; > + } > kirkwood_freq_table[1].frequency = clk_get_rate(priv.ddr_clk) / 1000; > > priv.powersave_clk = of_clk_get_by_name(np, "powersave"); There is one more prepare-enable after this. Why not fix that as well ? -- viresh