From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400AbdEQGx2 (ORCPT ); Wed, 17 May 2017 02:53:28 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41048 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdEQGx1 (ORCPT ); Wed, 17 May 2017 02:53:27 -0400 Date: Wed, 17 May 2017 08:53:17 +0200 From: Peter Zijlstra To: Tejun Heo Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, vincent.guittot@linaro.org, efault@gmx.de, pjt@google.com, clm@fb.com, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, bsegall@google.com, yuyang.du@intel.com, jbacik@fb.com Subject: Re: [RFC][PATCH 00/14] sched/fair: A bit of a cgroup/PELT overhaul (again).. Message-ID: <20170517065317.6abml7r4lcs2z57e@hirez.programming.kicks-ass.net> References: <20170512164416.108843033@infradead.org> <20170516220217.GA21241@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170516220217.GA21241@htj.duckdns.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2017 at 06:02:17PM -0400, Tejun Heo wrote: > Hello, > > On Fri, May 12, 2017 at 06:44:16PM +0200, Peter Zijlstra wrote: > > > > Hi all, > > > > So after staring at all that PELT stuff and working my way through it again: > > > > https://lkml.kernel.org/r/20170505154117.6zldxuki2fgyo53n@hirez.programming.kicks-ass.net > > > > I started doing some patches to fix some of the identified broken. > > > > So here are a few too many patches that do: > > > > - fix 'reweight_entity' to instantly propagate the change in se->load.weight. > > > > - rewrite/fix the propagate on migrate (attach/detach) > > > > - introduce the hierarchical runnable_load_avg, as proposed by Tejun. > > > > - synchronous detach for runnable migrates > > > > - aligns the PELT windows between a cfs_rq and all its se's > > > > - deals with random fallout from the above (some of this needs folding back > > and reordering, but its all well past the point I should post this anyway). > > The schbench results look good here. I'll put it under more realistic > test tomorrow and see how it performs. Josef reported some problems with these patches and narrowed it down to: "sched/fair: Remove se->load.weight from se->avg.load_sum" I'm currently stuck chasing a regression in other code, but I'll try and get back to this shortly.