From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155AbdEQJEQ (ORCPT ); Wed, 17 May 2017 05:04:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37192 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753933AbdEQJEO (ORCPT ); Wed, 17 May 2017 05:04:14 -0400 Date: Wed, 17 May 2017 10:04:07 +0100 From: Mark Brown To: Seraphime Kirkovski Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20170517090407.oc7d2hmydrsieli7@sirena.org.uk> References: <20170515081711.fcvexppqkjzlc7at@macchiaveli> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dk3md7hlq2zohmxu" Content-Disposition: inline In-Reply-To: <20170515081711.fcvexppqkjzlc7at@macchiaveli> X-Cookie: C for yourself. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] spi: spidev: introduce SPI_IOC_WR_DEFAULT_MAX_SPEED_HZ command X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dk3md7hlq2zohmxu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 15, 2017 at 10:17:11AM +0200, Seraphime Kirkovski wrote: > On Sun, May 14, 2017 at 06:27:16PM +0900, Mark Brown wrote: > > Do we have any evidence that such users exist? =20 > I can't guarantee for other such users, but this change did disturb our= =20 > workflow. We were using this feature to prototype and test=20 > hardware/firmware at different speeds. > I was thinking this morning that maybe a sysfs interface will be better= =20 > for setting global settings. Do you prefer ? I just don't see this as something that should be being varied at runtime; it is supposed to be the maximum speed that the bus can be run at, that's not something that should vary at runtime. Possibly a sysfs thing but honestly if you're prototyping via spidev I'd just set the speed in your application each time it starts. --dk3md7hlq2zohmxu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlkcEgYACgkQJNaLcl1U h9ArYgf9EuSwRkj9En7Yv89QcgdkbN1oFEgy/c9W0oCM1Y00dEwX8Ye6NxqWGPc7 0VSTQuDctMJXrbTNPvyVO0Kq8MvrN4p/atKtWg04u6XM7WB3LCRY3lir3uLja5mM D7WgXneRuuCoE/a0Xpu1WBsU88sI6ndDOEeCCiXOkf4tBL+egHTsvR9U9B4EYS/m NEXp0hnSXg9K/T/ha2TvTWSDYiNlL+YjqkCe4q0oQyVDkw6VpzXZbRdY3moEeKzI /QfyGJR53k+aWXHVCvqeRq9zY6ca/RrQPJZIIY8FqS4h+OzoRxTTPX0Gt82SE8/4 sSFm504ncY/GOVLS880MiQ+XXqM2ow== =dNGi -----END PGP SIGNATURE----- --dk3md7hlq2zohmxu--