From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932065AbdEQSGS (ORCPT ); Wed, 17 May 2017 14:06:18 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:34992 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754199AbdEQSGQ (ORCPT ); Wed, 17 May 2017 14:06:16 -0400 Date: Wed, 17 May 2017 11:06:11 -0700 From: Bjorn Andersson To: Baolin Wang Cc: ohad@wizery.com, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH v2] hwspinlock: sprd: Add hardware spinlock driver Message-ID: <20170517180611.GD12920@tuxbook> References: <5c2ac9be5fcfe0161952070ffdcb1cf7ed51128f.1495000470.git.baolin.wang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c2ac9be5fcfe0161952070ffdcb1cf7ed51128f.1495000470.git.baolin.wang@spreadtrum.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 16 May 22:59 PDT 2017, Baolin Wang wrote: > The Spreadtrum hardware spinlock device can provide hardware assistance > for synchronization between the multiple subsystems. > > Signed-off-by: Baolin Wang > --- > Changes since v1: > - Remove some unused macros and functions. > - Convert readl/writel_relaxed() to readl/writel. > - Remove some redundant error printing. > - Get clock with devm_clk_get(). > - Other small optimization. Looks good, merge this to my next branch before realizing that you didn't send a DT binding document. Can you please send a patch adding a binding document as well? (No need to resend this patch) Regards, Bjorn