From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbdEQTUY (ORCPT ); Wed, 17 May 2017 15:20:24 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:35406 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbdEQTUW (ORCPT ); Wed, 17 May 2017 15:20:22 -0400 Date: Wed, 17 May 2017 15:20:19 -0400 From: Tejun Heo To: Waiman Long Cc: Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de Subject: Re: [RFC PATCH v2 06/17] cgroup: Fix reference counting bug in cgroup_procs_write() Message-ID: <20170517192019.GB942@htj.duckdns.org> References: <1494855256-12558-1-git-send-email-longman@redhat.com> <1494855256-12558-7-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494855256-12558-7-git-send-email-longman@redhat.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 09:34:05AM -0400, Waiman Long wrote: > The cgroup_procs_write_start() took a reference to the task structure > which was not properly released within cgroup_procs_write() and so > on. So a put_task_struct() call is added to cgroup_procs_write_finish() > to match the get_task_struct() in cgroup_procs_write_start() to fix > this reference counting error. > > Signed-off-by: Waiman Long Acked-by: Tejun Heo Thanks! -- tejun