From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753689AbdEQVgq (ORCPT ); Wed, 17 May 2017 17:36:46 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:33705 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbdEQVgG (ORCPT ); Wed, 17 May 2017 17:36:06 -0400 Date: Wed, 17 May 2017 17:36:03 -0400 From: Tejun Heo To: Waiman Long Cc: Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de Subject: Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file Message-ID: <20170517213603.GE942@htj.duckdns.org> References: <1494855256-12558-1-git-send-email-longman@redhat.com> <1494855256-12558-9-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494855256-12558-9-git-send-email-longman@redhat.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Waiman. On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: > The debug cgroup currently resides within cgroup-v1.c and is enabled > only for v1 cgroup. To enable the debug cgroup also for v2, it > makes sense to put the code into its own file as it will no longer > be v1 specific. The only change in this patch is the expansion of > cgroup_task_count() within the debug_taskcount_read() function. > > Signed-off-by: Waiman Long I don't mind enabling the debug controller for v2 but let's please hide it behind an unwieldy boot param / controller name so that it's clear that its interface isn't expected to be stable. Thanks. -- tejun