From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753158AbdEQVnr (ORCPT ); Wed, 17 May 2017 17:43:47 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36540 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbdEQVnl (ORCPT ); Wed, 17 May 2017 17:43:41 -0400 Date: Wed, 17 May 2017 17:43:38 -0400 From: Tejun Heo To: Waiman Long Cc: Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de Subject: Re: [RFC PATCH v2 10/17] cgroup: Make debug cgroup support v2 and thread mode Message-ID: <20170517214338.GG942@htj.duckdns.org> References: <1494855256-12558-1-git-send-email-longman@redhat.com> <1494855256-12558-11-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494855256-12558-11-git-send-email-longman@redhat.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, May 15, 2017 at 09:34:09AM -0400, Waiman Long wrote: > Besides supporting cgroup v2 and thread mode, the following changes > are also made: > 1) current_* cgroup files now resides only at the root as we don't > need duplicated files of the same function all over the cgroup > hierarchy. > 2) The cgroup_css_links_read() function is modified to report > the number of tasks that are skipped because of overflow. > 3) The relationship between proc_cset and threaded_csets are displayed. > 4) The number of extra unaccounted references are displayed. > 5) The status of being a thread root or threaded cgroup is displayed. > 6) The current_css_set_read() function now prints out the addresses of > the css'es associated with the current css_set. > 7) A new cgroup_subsys_states file is added to display the css objects > associated with a cgroup. > 8) A new cgroup_masks file is added to display the various controller > bit masks in the cgroup. > > Signed-off-by: Waiman Long As noted before, please make it clear that this is a debug feature and not expected to be stable. Also, I don't see why this and the previous two patches are in this series. Can you please split these out to a separate patchset? Thanks. -- tejun