From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755979AbdEROGl (ORCPT ); Thu, 18 May 2017 10:06:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43104 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbdEROGj (ORCPT ); Thu, 18 May 2017 10:06:39 -0400 Date: Thu, 18 May 2017 10:06:08 -0400 (EDT) Message-Id: <20170518.100608.733334484371439292.davem@davemloft.net> To: xiaolou4617@gmail.com Cc: andrew.hendry@gmail.com, linux-x25@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3] net: x25: fix one potential use-after-free issue From: David Miller In-Reply-To: <1494993907-22727-1-git-send-email-xiaolou4617@gmail.com> References: <1494993907-22727-1-git-send-email-xiaolou4617@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 May 2017 06:25:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: linzhang Date: Wed, 17 May 2017 12:05:07 +0800 > The function x25_init is not properly unregister related resources > on error handler.It is will result in kernel oops if x25_init init > failed, so add properly unregister call on error handler. > > Also, i adjust the coding style and make x25_register_sysctl properly > return failure. > > Signed-off-by: linzhang Applied, thanks.