From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755292AbdESCbR (ORCPT ); Thu, 18 May 2017 22:31:17 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49672 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755210AbdESCbP (ORCPT ); Thu, 18 May 2017 22:31:15 -0400 Date: Thu, 18 May 2017 22:31:13 -0400 (EDT) Message-Id: <20170518.223113.1783186374793423172.davem@davemloft.net> To: babu.moger@oracle.com Cc: peterz@infradead.org, mingo@redhat.com, arnd@arndb.de, shannon.nelson@oracle.com, haakon.bugge@oracle.com, steven.sistare@oracle.com, vijay.ac.kumar@oracle.com, jane.chu@oracle.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC From: David Miller In-Reply-To: <1495154170-854693-5-git-send-email-babu.moger@oracle.com> References: <1495154170-854693-1-git-send-email-babu.moger@oracle.com> <1495154170-854693-5-git-send-email-babu.moger@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 May 2017 18:49:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Babu Moger Date: Thu, 18 May 2017 18:36:08 -0600 > @@ -82,6 +82,7 @@ config SPARC64 > select HAVE_ARCH_AUDITSYSCALL > select ARCH_SUPPORTS_ATOMIC_RMW > select HAVE_NMI > + select ARCH_USE_QUEUED_RWLOCKS > If you are selecting this on SPARC64 all the time, then: > @@ -94,6 +94,7 @@ static inline void arch_spin_lock_flags(arch_spinlock_t *lock, unsigned long fla > : "memory"); > } > > +#ifndef CONFIG_QUEUED_RWLOCKS > /* Multi-reader locks, these are much saner than the 32-bit Sparc ones... */ You can remove this segment of ifdef'd code altogether since it is in a sparc64 specific header file.