From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754840AbdERB5B (ORCPT ); Wed, 17 May 2017 21:57:01 -0400 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:61778 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752974AbdERB45 (ORCPT ); Wed, 17 May 2017 21:56:57 -0400 Date: Thu, 18 May 2017 09:54:54 +0800 From: Baolin Wang To: Bjorn Andersson CC: , , , , Subject: Re: [PATCH v2] hwspinlock: sprd: Add hardware spinlock driver Message-ID: <20170518015453.GB14416@spreadtrum.com> Mail-Followup-To: Bjorn Andersson , ohad@wizery.com, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org References: <5c2ac9be5fcfe0161952070ffdcb1cf7ed51128f.1495000470.git.baolin.wang@spreadtrum.com> <20170517180611.GD12920@tuxbook> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170517180611.GD12920@tuxbook> User-Agent: Mutt/1.5.21 (2010-09-15) X-MAIL: SHSQR01.spreadtrum.com v4I1uR4t027250 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 三, 5月 17, 2017 at 11:06:11上午 -0700, Bjorn Andersson wrote: > On Tue 16 May 22:59 PDT 2017, Baolin Wang wrote: > > > The Spreadtrum hardware spinlock device can provide hardware assistance > > for synchronization between the multiple subsystems. > > > > Signed-off-by: Baolin Wang > > --- > > Changes since v1: > > - Remove some unused macros and functions. > > - Convert readl/writel_relaxed() to readl/writel. > > - Remove some redundant error printing. > > - Get clock with devm_clk_get(). > > - Other small optimization. > > Looks good, merge this to my next branch before realizing that you > didn't send a DT binding document. > > Can you please send a patch adding a binding document as well? (No need > to resend this patch) Sure, I will send out the patches adding binding cocument and dts. Thanks.