From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbdERFKT (ORCPT ); Thu, 18 May 2017 01:10:19 -0400 Received: from [128.1.224.119] ([128.1.224.119]:41826 "EHLO deadmen.hmeau.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751155AbdERFKQ (ORCPT ); Thu, 18 May 2017 01:10:16 -0400 Date: Thu, 18 May 2017 13:09:34 +0800 From: Herbert Xu To: Gilad Ben-Yossef Cc: "David S. Miller" , Jonathan Corbet , David Howells , Ofir Drang , Gilad Ben-Yossef , Eric Biggers , stable@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/4] crypto: drbg wait for crypto op not signal safe Message-ID: <20170518050933.GA32409@gondor.apana.org.au> References: <1494503626-15877-1-git-send-email-gilad@benyossef.com> <1494503626-15877-3-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494503626-15877-3-git-send-email-gilad@benyossef.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 02:53:43PM +0300, Gilad Ben-Yossef wrote: > drbg_kcapi_sym_ctr() was using wait_for_completion_interruptible() to > wait for completion of async crypto op but if a signal occurs it > may return before DMA ops of HW crypto provider finish, thus > corrupting the output buffer. > > Resolve this by using wait_for_completion() instead. > > Reported-by: Eric Biggers > Signed-off-by: Gilad Ben-Yossef > CC: stable@vger.kernel.org This patch doesn't even compile. Please test your work first. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt