From: Borislav Petkov <bp@alien8.de>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32
Date: Thu, 18 May 2017 10:08:40 +0200 [thread overview]
Message-ID: <20170518080840.fnoiauo5aq4qqgv2@pd.tnic> (raw)
In-Reply-To: <7c7bfec63342409ebd58913836a0739a@svr-chch-ex1.atlnz.lc>
On Wed, May 17, 2017 at 09:16:47PM +0000, Chris Packham wrote:
> MV64x60 is pretty old. I considered gutting mv64x60_edac.c to make a
> separate driver but that would just be more code to maintain.
Well, one thing we did with layerscape and mpc85xx EDAC modules is share
the FSL memory controller IP through fsl_ddr_edac.c which both modules
link.
I dunno, perhaps you could do something similar by extracting the common
parts and this way avoid any breakage of the PPC side of things - since
apparently finding such hw is not easy - and then link those into your
driver. And your driver could just be a wrapper containing the EDAC glue
to make it a separate ARM armada_edac.c or so.
Anyway, just an idea.
Thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-05-18 8:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170512042002.18524-1-chris.packham@alliedtelesis.co.nz>
2017-05-12 4:20 ` [PATCH 1/3] EDAC: mv64x60: remove unused variable Chris Packham
2017-05-12 4:20 ` [PATCH 2/3] EDAC: mv64x60: Fix pdata->name Chris Packham
2017-05-12 4:20 ` [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Chris Packham
2017-05-17 18:10 ` Borislav Petkov
2017-05-17 21:16 ` Chris Packham
2017-05-17 21:40 ` Arnd Bergmann
2017-05-19 14:01 ` David Laight
2017-05-19 15:25 ` Arnd Bergmann
2017-05-18 8:08 ` Borislav Petkov [this message]
2017-05-18 5:36 ` Michael Ellerman
2017-05-18 11:07 ` Arnd Bergmann
2017-05-19 9:53 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518080840.fnoiauo5aq4qqgv2@pd.tnic \
--to=bp@alien8.de \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®